Skip to content

[WIP] Refactoring: make client package for client related annotations.#12212

Closed
mneverov wants to merge 1 commit intokubernetes:mainfrom
mneverov:client-body-timeout-annotation
Closed

[WIP] Refactoring: make client package for client related annotations.#12212
mneverov wants to merge 1 commit intokubernetes:mainfrom
mneverov:client-body-timeout-annotation

Conversation

@mneverov
Copy link
Member

@mneverov mneverov commented Oct 20, 2024

What this PR does / why we need it:

This PR introduces client package for client-header- and client-body- related annotations. This is the first step to add client-body-timeout annotations.
Addresses refactoring part of #12177

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • CVE Report (Scanner found CVE and adding report)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation only

None above: refactoring only.

Which issue/s this PR fixes

partially fixes #12177

How Has This Been Tested?

make test; lua-test; kind-e2e-test

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I've read the CONTRIBUTION guide
  • I have added unit and/or e2e tests to cover my changes.
  • All new and existing tests passed.

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Oct 20, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Oct 20, 2024
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Oct 20, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: mneverov
Once this PR has been reviewed and has the lgtm label, please assign gacko for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Oct 20, 2024

This issue is currently awaiting triage.

If Ingress contributors determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-priority size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 20, 2024
@netlify
Copy link

netlify bot commented Oct 20, 2024 •
edited
Loading

✅ Deploy Preview for kubernetes-ingress-nginx ready!

Name Link
🔨 Latest commit cb99d97
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-ingress-nginx/deploys/67144be1b794ca00085f1bb5
😎 Deploy Preview https://deploy-preview-12212--kubernetes-ingress-nginx.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@mneverov mneverov force-pushed the client-body-timeout-annotation branch from 5c6505d to cb99d97 Compare October 20, 2024 00:16
@Anddd7 Anddd7 mentioned this pull request Dec 5, 2024
Merged
6 tasks
@github-actions
Copy link

github-actions bot commented Jan 30, 2025

This is stale, but we won't close it automatically, just bare in mind the maintainers may be busy with other tasks and will reach your issue ASAP. If you have any question or request to prioritize this, please reach #ingress-nginx-dev on Kubernetes Slack.

@github-actions github-actions bot added the lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. label Jan 30, 2025
@k8s-triage-robot
Copy link

k8s-triage-robot commented Jan 30, 2025

The lifecycle/frozen label can not be applied to PRs.

This bot removes lifecycle/frozen from PRs because:

  • Commenting /lifecycle frozen on a PR has not worked since March 2021
  • PRs that remain open for >150 days are unlikely to be easily rebased

You can:

  • Rebase this PR and attempt to get it merged
  • Close this PR with /close

Please send feedback to sig-contributor-experience at kubernetes/community.

/remove-lifecycle frozen

@k8s-ci-robot k8s-ci-robot removed the lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. label Jan 30, 2025
@Gacko Gacko closed this Dec 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@strongjz strongjz Awaiting requested review from strongjz

@tao12345666333 tao12345666333 Awaiting requested review from tao12345666333

Assignees

No one assigned

Labels

area/docs cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-priority needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Support client_body_timeout annotation

4 participants

@mneverov @k8s-ci-robot @k8s-triage-robot @Gacko